Skip to content

[18.0][MIG] account_payment_mode: Migration to version 18.0#1438

Merged
OCA-git-bot merged 69 commits intoOCA:18.0from
Tecnativa:18.0-mig-account_payment_mode
Apr 16, 2025
Merged

[18.0][MIG] account_payment_mode: Migration to version 18.0#1438
OCA-git-bot merged 69 commits intoOCA:18.0from
Tecnativa:18.0-mig-account_payment_mode

Conversation

@carlos-lopez-tecnativa
Copy link
Copy Markdown
Contributor

@carlos-lopez-tecnativa carlos-lopez-tecnativa commented Mar 26, 2025

Supersedes #1367
TT54087
@Tecnativa @pedrobaeza @carlosdauden @juancarlosonate-tecnativa could you please review this?

alexis-via and others added 30 commits March 26, 2025 09:12
…lot of improvements) during the Sorrento Code sprint 2016

Improvements include:

- full re-organisation of modules and big re-organisation of the code
- simplification of the code related to the fact that support for direct debit is now in t
he base module, not added by an optional module account_direct_debit (module was removed)
- new design of the wizard to select move lines to pay
- support for non-SEPA file transfer-
- support for German direct debit SEPA files (fixes bug OCA#129)
- remove workflow of payment.order

- Finalise the wizard of selection of move lines to pay

  Add button "Add to payment/debit order" on invoice form view
  Started to integrate payment transfer in account_payment_order (not finished at all though)
  Various fixes/changes/improvements/...

- Update and re-enable demo data
- Move field bank_account_required from module account_payment_partner to account_payment_mode

  Make the mandate a required field on payment line when the payment method has mandate_required=True
  Make the bank account a required field on payment line when the payment method has bank_account_required=True

- Enable the payment methods by default on bank journals (including existing bank journals via post_install scripts)
Port almost all modules to v10

* Update to EPC Rulebook v9.2 that start to apply on 2016-11-20 (bug OCA#300)
* Fix payment method onchange with multicompany (OCA#374)
* Add relational inverse field for payment.mode on payment.method
…+ fix

- FIX: Don't store acc_type of res.partner.bank (OCA#467)
- when manually encoding a payment line, get company currency as default currency
- Search on payment order numbers
- Direct search on bank journal name in payment orders
- remove widget="selection" on account.payement.mode : this object is rarely modified, so widget='selection' is not a time saver, but we miss the HTML link, which can be pretty convenient to check the configuration.
Currently translated at 100,0% (51 of 51 strings)

Translation: bank-payment-11.0/bank-payment-11.0-account_payment_mode
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-11-0/bank-payment-11-0-account_payment_mode/es/
Description of the issue/feature this PR addresses:

The modules adds `{'invisible': [('parent_id', '!=', False)]}` attribute
to `banks` group on res.partner form view. The rationale for this,
according to a comment on the view itself is:
> ... there is a domain on the 'partner_id' field of res.partner.bank
(base module) which prevents the selection of a contact

However, the domain the comment refers to is
`['|', ('is_company', '=', True), ('parent_id', '=', False)]`
So, I think the domain for the group to be invisible should be
`[('parent_id', '!=', False), ('is_company', '=', False)]`. In addition,
a parent that is a company is always its own commercial partner. So we
should have access to its payment information.

Current behavior before PR:

Bank and mandates information is hidden when a partner is a company and
has a parent.

Desired behavior after PR is merged:

Banking information should be visible if a partner is a company.
Currently translated at 49.1% (27 of 55 strings)

Translation: bank-payment-12.0/bank-payment-12.0-account_payment_mode
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-12-0/bank-payment-12-0-account_payment_mode/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: bank-payment-13.0/bank-payment-13.0-account_payment_mode
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-13-0/bank-payment-13-0-account_payment_mode/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: bank-payment-13.0/bank-payment-13.0-account_payment_mode
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-13-0/bank-payment-13-0-account_payment_mode/
Update "development_status": "Production/Stable"
Copy link
Copy Markdown
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvalyi
Copy link
Copy Markdown
Member

rvalyi commented Mar 26, 2025

Hello, I don't pretend to close the debate about this with @alexis-via but simply remind you that the usage of this module is questioned by @alexis-via which is also the main author of the account_payment_order module, so good to check that with him... #1364 (comment) also read https://odoo-community.org/groups/contributors-15/contributors-2029602?mode=thread&date_begin=&date_end=

Comment thread account_payment_mode/security/account_payment_mode.xml Outdated
@carlos-lopez-tecnativa carlos-lopez-tecnativa force-pushed the 18.0-mig-account_payment_mode branch from 5e24a8e to b82c3f2 Compare March 27, 2025 10:50
Comment thread account_payment_mode/migrations/18.0.1.0.0/post-migration.py Outdated
@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Comment thread account_payment_mode/views/account_payment_method.xml Outdated
Comment thread account_payment_mode/views/account_payment_mode.xml Outdated
@pilarvargas-tecnativa
Copy link
Copy Markdown
Contributor

please include #1445

@carlos-lopez-tecnativa carlos-lopez-tecnativa force-pushed the 18.0-mig-account_payment_mode branch from 70d9e0f to f64d82c Compare April 15, 2025 13:48
@carlos-lopez-tecnativa
Copy link
Copy Markdown
Contributor Author

please include #1445

Done

@pedrobaeza
Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-1438-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1efed71 into OCA:18.0 Apr 16, 2025
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 233f951. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 18.0-mig-account_payment_mode branch April 16, 2025 19:14
Vicent-S73 pushed a commit to Studio73/e-commerce that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.